WIP: Add a test for a query that produces a nil :db/id#301
Open
devurandom wants to merge 1 commit intotonsky:masterfrom
Open
WIP: Add a test for a query that produces a nil :db/id#301devurandom wants to merge 1 commit intotonsky:masterfrom
nil :db/id#301devurandom wants to merge 1 commit intotonsky:masterfrom
Conversation
Owner
|
The query is invalid, the problem is validation isn't picking |
devurandom
force-pushed
the
test/or-creates-nil-id
branch
from
96b91c2 to
76c6adc
Compare
…f evaluating to `nil`
devurandom
force-pushed
the
test/or-creates-nil-id
branch
from
76c6adc to
dff6bfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attached commit adds a test that currently produces a
nil:db/id, which seems wrong. Since I do not know what the correct result should be, I am treating this as work-in-progress for now.